Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plane:remove stale conversion code #29024

Merged

Conversation

peterbarker
Copy link
Contributor

@peterbarker peterbarker commented Jan 8, 2025

these lines are all present in 4.0.0.

Past this PR we won't convert PIDS correctly if someone attempts to upgrade to 4.7+ from 3.x

Board                    AP_Periph  blimp  bootloader  copter  heli  iofirmware  plane  rover  sub
CubeOrange-periph-heavy  *
CubeRedPrimary                      *      *           *       *                 -1296  *      *
Durandal                            *      *           *       *                 -1504  *      *
Hitec-Airspeed           *
KakuteH7-bdshot                     *      *           *       *                 -1296  *      *
MatekF405                           *      *           *       *                 -1288  *      *
Pixhawk1-1M-bdshot                  *                  *       *                 -1288  *      *
bebop                               *                  *       *                 0      *      *
f103-QiotekPeriph        *
f303-Universal           *
iomcu                                                                *
revo-mini                           *      *           *       *                 -1288  *      *
skyviper-v2450                                         *

ArduPlane/quadplane.cpp Outdated Show resolved Hide resolved
Copy link
Member

@IamPete1 IamPete1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

these lines are all present in 4.0.0.

Past this PR we won't convert PIDS correctly if someone attempts to upgrade to 4.7+ from 3.x
@peterbarker peterbarker force-pushed the pr/remove-old-q-conversion branch from 2bcfd76 to 1683a95 Compare January 13, 2025 22:26
@peterbarker peterbarker merged commit fadc293 into ArduPilot:master Jan 14, 2025
69 checks passed
@peterbarker peterbarker deleted the pr/remove-old-q-conversion branch January 14, 2025 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants